Review Request: QLatin1String-ify comparisons to QString.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100729/#review1622
-----------------------------------------------------------

Ship it!


To ensure that conversions from C-string to QString are not used anywhere "add_definitions(QT_NO_CAST_FROM_ASCII)" should be added in CMakeLists.txt

- Daniele Elmo


On Feb. 24, 2011, 12:01 a.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100729/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2011, 12:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> QLatin1String-ify comparisons to QString as suggested by
> 
> http://developer.qt.nokia.com/wiki/UsingQStringEffectively
> 
> 
> Diffs
> -----
> 
>   butterfly/butterfly-account-ui-plugin.cpp ba40ce3a8b480be84d97ff01d0004157fda5c4ff 
>   gabble/gabble-account-ui-plugin.cpp 12b58e5be3f77b09f1748406f084864c3445bd1c 
>   haze/haze-account-ui-plugin.cpp 47551fe65e588d77adc5c61e97b9fe0ecd195044 
>   idle/idle-account-ui-plugin.cpp c3ff4a150de23bbc595d4b50cd63cc3517dec294 
>   rakia/rakia-account-ui-plugin.cpp f61bb4c9a64c50b2d2dfcd885331cbffff0adba1 
> 
> Diff: http://git.reviewboard.kde.org/r/100729/diff
> 
> 
> Testing
> -------
> 
> compiled and installed
> plugins still load.
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110224/b58f2ae8/attachment.htm