<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100729/">http://git.reviewboard.kde.org/r/100729/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To ensure that conversions from C-string to QString are not used anywhere "add_definitions(QT_NO_CAST_FROM_ASCII)" should be added in CMakeLists.txt</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On February 24th, 2011, 12:01 a.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2011, 12:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1String-ify comparisons to QString as suggested by
http://developer.qt.nokia.com/wiki/UsingQStringEffectively</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled and installed
plugins still load.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>butterfly/butterfly-account-ui-plugin.cpp <span style="color: grey">(ba40ce3a8b480be84d97ff01d0004157fda5c4ff)</span></li>
<li>gabble/gabble-account-ui-plugin.cpp <span style="color: grey">(12b58e5be3f77b09f1748406f084864c3445bd1c)</span></li>
<li>haze/haze-account-ui-plugin.cpp <span style="color: grey">(47551fe65e588d77adc5c61e97b9fe0ecd195044)</span></li>
<li>idle/idle-account-ui-plugin.cpp <span style="color: grey">(c3ff4a150de23bbc595d4b50cd63cc3517dec294)</span></li>
<li>rakia/rakia-account-ui-plugin.cpp <span style="color: grey">(f61bb4c9a64c50b2d2dfcd885331cbffff0adba1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100729/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>