Review Request: Added advanced options widget to haze-yahoo

[Lasath Fernando]

> On Feb. 18, 2011, 2:27 p.m., George Kiagiadakis wrote:
> > rakia/kcmtelepathyaccounts_plugin_rakia.desktop, lines 4-11
> > <http://git.reviewboard.kde.org/r/100678/diff/1/?file=9441#file9441line4>
> >
> >     Something is wrong here with the diff. These things should not appear.

Does that mean it will affect anything? 
Because (if you were there) you might recall I had a VERY unpleasant experience with git recently.


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100678/#review1487
-----------------------------------------------------------


On Feb. 18, 2011, 1:01 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100678/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 1:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Created an advanced options widget to go with the haze-yahoo plugin I made earlier.
> 
> 
> Diffs
> -----
> 
>   haze/CMakeLists.txt 49711ad 
>   haze/haze-yahoo-account.cpp 7cdad17 
>   haze/yahoo-main-options-widget.cpp f07822d 
>   haze/yahoo-server-settings-widget.h PRE-CREATION 
>   haze/yahoo-server-settings-widget.cpp PRE-CREATION 
>   haze/yahoo-server-settings-widget.ui PRE-CREATION 
>   rakia/kcmtelepathyaccounts_plugin_rakia.desktop fb11dda 
>   rakia/rakia-main-options-widget.ui 9ba9ef2 
> 
> Diff: http://git.reviewboard.kde.org/r/100678/diff
> 
> 
> Testing
> -------
> 
> Applied changes and made sure they were reflected in empathy
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110219/110173be/attachment.htm