Review Request: Added advanced options widget to haze-yahoo

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100678/#review1487
-----------------------------------------------------------



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1266>

    Remove trailing whitespace.



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1265>

    Remove trailing whitespace.



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1264>

    i18n("Advanced")



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1263>

    Shouldn't this one have a camelcase header?



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1261>

    Remove trailing whitespace.



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1260>

    Remove trailing whitespace.



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1259>

    Use const Tp::ProtocolParameter &



haze/yahoo-server-settings-widget.cpp
<http://git.reviewboard.kde.org/r/100678/#comment1258>

    Remove trailing whitespace.



rakia/kcmtelepathyaccounts_plugin_rakia.desktop
<http://git.reviewboard.kde.org/r/100678/#comment1256>

    Something is wrong here with the diff. These things should not appear.



rakia/rakia-main-options-widget.ui
<http://git.reviewboard.kde.org/r/100678/#comment1257>

    This one shouldn't appear as well... This is already commited.


- George


On Feb. 18, 2011, 1:01 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100678/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 1:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Created an advanced options widget to go with the haze-yahoo plugin I made earlier.
> 
> 
> Diffs
> -----
> 
>   haze/CMakeLists.txt 49711ad 
>   haze/haze-yahoo-account.cpp 7cdad17 
>   haze/yahoo-main-options-widget.cpp f07822d 
>   haze/yahoo-server-settings-widget.h PRE-CREATION 
>   haze/yahoo-server-settings-widget.cpp PRE-CREATION 
>   haze/yahoo-server-settings-widget.ui PRE-CREATION 
>   rakia/kcmtelepathyaccounts_plugin_rakia.desktop fb11dda 
>   rakia/rakia-main-options-widget.ui 9ba9ef2 
> 
> Diff: http://git.reviewboard.kde.org/r/100678/diff
> 
> 
> Testing
> -------
> 
> Applied changes and made sure they were reflected in empathy
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110218/39751178/attachment-0001.htm