Review Request: port krdc and krfb to telepathy-qt4 0.5

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6441/#review9889
-----------------------------------------------------------

Ship it!


Looks good. Only a few minor changes needed, and then you can commit it.


trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment11051>

    Better put this include grouped together with the other TelepathyQt4 includes



trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment11050>

    Change this to TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE, so that it works with QT_NO_CAST_FROM_ASCII defined.



trunk/KDE/kdenetwork/krdc/tubesmanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment11052>

    TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE



trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment11049>

    TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE


- George


On Feb. 19, 2011, 2:04 a.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6441/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 2:04 a.m.)
> 
> 
> Review request for telepathy.
> 
> 
> Summary
> -------
> 
> port krdc and krfb to telepathy-qt4 0.5 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approver.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tube.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.h 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesrfbserver.cpp 1218014 
> 
> Diff: http://svn.reviewboard.kde.org/r/6441/diff
> 
> 
> Testing
> -------
> 
> compiles against tp-qt4 master (18.02.2011)
> tested with a patched contact-list from mck182's branch with two jabber accounts on two computers in the same local net.
> 
> http://quickgit.kde.org/?p=clones/telepathy-contact-list/reinhard/telepathy-contact-list.git&a=summary
> branch: sharedesktop
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110219/5fca2150/attachment-0001.htm