<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6441/">http://svn.reviewboard.kde.org/r/6441/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Only a few minor changes needed, and then you can commit it.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6441/diff/5/?file=45059#file45059line40" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <TelepathyQt4/Account></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better put this include grouped together with the other TelepathyQt4 includes</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6441/diff/5/?file=45059#file45059line45" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">filter0</span><span class="p">[</span><span class="n">TELEPATHY_INTERFACE_CHANNEL</span> <span class="s">".ChannelType"</span><span class="p">]</span> <span class="o">=</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">spec</span><span class="p">.</span><span class="n">setChannelType</span><span class="p">(</span><span class="n">TELEPATHY_INTERFACE_CHANNEL_TYPE_STREAM_TUBE</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change this to TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE, so that it works with QT_NO_CAST_FROM_ASCII defined.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6441/diff/5/?file=45062#file45062line35" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdenetwork/krdc/tubesmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">filter0</span><span class="p">[</span><span class="n">TELEPATHY_INTERFACE_CHANNEL</span> <span class="s">".ChannelType"</span><span class="p">]</span> <span class="o">=</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">spec</span><span class="p">.</span><span class="n">setChannelType</span><span class="p">(</span><span class="n">TELEPATHY_INTERFACE_CHANNEL_TYPE_STREAM_TUBE</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6441/diff/5/?file=45064#file45064line35" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">filter0</span><span class="p">[</span><span class="n">TELEPATHY_INTERFACE_CHANNEL</span> <span class="s">".ChannelType"</span><span class="p">]</span> <span class="o">=</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">spec</span><span class="p">.</span><span class="n">setChannelType</span><span class="p">(</span><span class="n">TELEPATHY_INTERFACE_CHANNEL_TYPE_STREAM_TUBE</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TP_QT4_IFACE_CHANNEL_TYPE_STREAM_TUBE</pre>
</div>
<br />
<p>- George</p>
<br />
<p>On February 19th, 2011, 2:04 a.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2011, 2:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">port krdc and krfb to telepathy-qt4 0.5 </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles against tp-qt4 master (18.02.2011)
tested with a patched contact-list from mck182's branch with two jabber accounts on two computers in the same local net.
http://quickgit.kde.org/?p=clones/telepathy-contact-list/reinhard/telepathy-contact-list.git&a=summary
branch: sharedesktop</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdenetwork/krdc/krdc_approver/approver.cpp <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.h <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krdc/tube.cpp <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krdc/tubesmanager.h <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krdc/tubesmanager.cpp <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.h <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp <span style="color: grey">(1218014)</span></li>
<li>trunk/KDE/kdenetwork/krfb/krfb/tubesrfbserver.cpp <span style="color: grey">(1218014)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>