Review Request: Implement unread messages in the lib and show the status in the app

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100594/#review1291
-----------------------------------------------------------


Summary of a small IRC meeting
 - incrementMessageCount should be private.
 - resetUnreadMessageCount should be private, as the library is tracking if it has been seen or not. A mix of styles is bad.
 - unreadMessages to be renamed to unreadMessagesCount to make the return type obvious.
 - showOnTop doesn't actually guarantee it is shown, therefore it should be removed from the library and it is up the application to make sure the widget is shown if they want to reset the unread message counter.

- David


On Feb. 7, 2011, 1:09 a.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100594/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2011, 1:09 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Hopefully you like this one better :P
> 
> Now the chatWidget doesn't know anything about a tab which it could be, only about the unread messages based on isActiveWindow() and isVisible() this behaviour can be overriden (or completely disabled) in a subclass.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 738a3b6 
>   app/chattab.h PRE-CREATION 
>   app/chattab.cpp PRE-CREATION 
>   app/chatwindow.h e6e2ffd 
>   app/chatwindow.cpp 5cf2ea0 
>   app/telepathychatui.h 1cfe76c 
>   app/telepathychatui.cpp 4415c82 
>   lib/chatwidget.h c4b3945 
>   lib/chatwidget.cpp a559adc 
> 
> Diff: http://git.reviewboard.kde.org/r/100594/diff
> 
> 
> Testing
> -------
> 
> Works fine for me.
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110207/4b662ef7/attachment-0001.htm