<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100594/">http://git.reviewboard.kde.org/r/100594/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Summary of a small IRC meeting
- incrementMessageCount should be private.
- resetUnreadMessageCount should be private, as the library is tracking if it has been seen or not. A mix of styles is bad.
- unreadMessages to be renamed to unreadMessagesCount to make the return type obvious.
- showOnTop doesn't actually guarantee it is shown, therefore it should be removed from the library and it is up the application to make sure the widget is shown if they want to reset the unread message counter.</pre>
<br />
<p>- David</p>
<br />
<p>On February 7th, 2011, 1:09 a.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2011, 1:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hopefully you like this one better :P
Now the chatWidget doesn't know anything about a tab which it could be, only about the unread messages based on isActiveWindow() and isVisible() this behaviour can be overriden (or completely disabled) in a subclass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/CMakeLists.txt <span style="color: grey">(738a3b6)</span></li>
<li>app/chattab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chattab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chatwindow.h <span style="color: grey">(e6e2ffd)</span></li>
<li>app/chatwindow.cpp <span style="color: grey">(5cf2ea0)</span></li>
<li>app/telepathychatui.h <span style="color: grey">(1cfe76c)</span></li>
<li>app/telepathychatui.cpp <span style="color: grey">(4415c82)</span></li>
<li>lib/chatwidget.h <span style="color: grey">(c4b3945)</span></li>
<li>lib/chatwidget.cpp <span style="color: grey">(a559adc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100594/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>