Review Request: More improvements for the chatwindow

[Dominik Schmidt]

> On Feb. 6, 2011, 12:56 p.m., David Edmundson wrote:
> > The library chatWidget should have no concept of TabWidgets. There should be many other apps that use the chatWidget in different ways.
> >  I dont want this merging until this is addressed. Will discuss on IRC when Im back.
> > 
> > Also - dont put lots of things into a single review. It makes it really difficult to read.

Sorry for the big diff, was in a hurry yesterday and wanted to upload it before I had to leave.


You're totally right about turning it into a "TabWidget", I'll try moving as much as much as possible into a (ChatTab called) subclass (will be more convenient anyways), file a more readable review request :P and then we can decide whether it should go to the lib or the app, agreed?


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100581/#review1266
-----------------------------------------------------------


On Feb. 5, 2011, 8:34 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100581/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2011, 8:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Most important change: show colors on the tabs.
> 
> 
> P.S.: Ignore the config/-dir, i will clean this up before pushing, just want a first comment on what i did for the colors
> 
> 
> Diffs
> -----
> 
>   app/chatwindow.cpp 5cf2ea0 
>   app/chatwindow.h e6e2ffd 
>   adiumxtra-protocol-handler/CMakeLists.txt 514aa87 
>   app/CMakeLists.txt 738a3b6 
>   app/main.cpp 06281e2 
>   app/telepathychatui.h 1cfe76c 
>   app/telepathychatui.cpp 4415c82 
>   config/CMakeLists.txt 6d1e900 
>   config/chatwindowconfig.ui bd3faf2 
>   config/kcm-telepathy-chat.h PRE-CREATION 
>   config/kcm-telepathy-chat.cpp PRE-CREATION 
>   config/kcm_telepathy_chat.desktop PRE-CREATION 
>   config/main.cpp 03f5633 
>   lib/CMakeLists.txt f4e46aa 
>   lib/chatwidget.h c4b3945 
>   lib/chatwidget.cpp a559adc 
> 
> Diff: http://git.reviewboard.kde.org/r/100581/diff
> 
> 
> Testing
> -------
> 
> Tested it, but please tell me the smallest glitch you find. Those I know of:
> - on status change the chatview doesn't scroll down
> - no decent default size on the first startup of the chatwindow
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110206/d90c483d/attachment.htm