<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100581/">http://git.reviewboard.kde.org/r/100581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2011, 12:56 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The library chatWidget should have no concept of TabWidgets. There should be many other apps that use the chatWidget in different ways.
I dont want this merging until this is addressed. Will discuss on IRC when Im back.
Also - dont put lots of things into a single review. It makes it really difficult to read.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the big diff, was in a hurry yesterday and wanted to upload it before I had to leave.
You're totally right about turning it into a "TabWidget", I'll try moving as much as much as possible into a (ChatTab called) subclass (will be more convenient anyways), file a more readable review request :P and then we can decide whether it should go to the lib or the app, agreed?</pre>
<br />
<p>- Dominik</p>
<br />
<p>On February 5th, 2011, 8:34 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2011, 8:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most important change: show colors on the tabs.
P.S.: Ignore the config/-dir, i will clean this up before pushing, just want a first comment on what i did for the colors</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it, but please tell me the smallest glitch you find. Those I know of:
- on status change the chatview doesn't scroll down
- no decent default size on the first startup of the chatwindow</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chatwindow.cpp <span style="color: grey">(5cf2ea0)</span></li>
<li>app/chatwindow.h <span style="color: grey">(e6e2ffd)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: grey">(514aa87)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(738a3b6)</span></li>
<li>app/main.cpp <span style="color: grey">(06281e2)</span></li>
<li>app/telepathychatui.h <span style="color: grey">(1cfe76c)</span></li>
<li>app/telepathychatui.cpp <span style="color: grey">(4415c82)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(6d1e900)</span></li>
<li>config/chatwindowconfig.ui <span style="color: grey">(bd3faf2)</span></li>
<li>config/kcm-telepathy-chat.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm-telepathy-chat.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm_telepathy_chat.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/main.cpp <span style="color: grey">(03f5633)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(f4e46aa)</span></li>
<li>lib/chatwidget.h <span style="color: grey">(c4b3945)</span></li>
<li>lib/chatwidget.cpp <span style="color: grey">(a559adc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100581/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>