Review Request: ChatUi: Refactor

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100547/#review1216
-----------------------------------------------------------

Ship it!


It's good. There's still a tonne of ideas left to implement with multiple windows - and I think in the future we should be a KUniqueApplication, as there's no reason to load two instances of this.

Only concern with this change is the status bar:
We should either use it, or get rid of it.
If we do use it, there should be no option to turn it off, and if we don't, no reason to turn it on.

(at one point I seem to remember it saying "foo is typing a message", the concern here is that when we embed the chatWidget into another app, we don't (and shouldn't?) have control of the status bar.

This can go on the discussion list.


- David


On Feb. 4, 2011, 12:43 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100547/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 12:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Use a proper KXmlGuiWindow and flexible structure.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 86bea23 
>   app/chatwindow.h PRE-CREATION 
>   app/chatwindow.cpp PRE-CREATION 
>   app/chatwindow.rc PRE-CREATION 
>   app/main.cpp 9ef06f9 
>   app/mainwindow.h badff27 
>   app/mainwindow.cpp 54ac071 
>   app/telepathychatui.h PRE-CREATION 
>   app/telepathychatui.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100547/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110204/ebba8557/attachment.htm