<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100547/">http://git.reviewboard.kde.org/r/100547/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's good. There's still a tonne of ideas left to implement with multiple windows - and I think in the future we should be a KUniqueApplication, as there's no reason to load two instances of this.
Only concern with this change is the status bar:
We should either use it, or get rid of it.
If we do use it, there should be no option to turn it off, and if we don't, no reason to turn it on.
(at one point I seem to remember it saying "foo is typing a message", the concern here is that when we embed the chatWidget into another app, we don't (and shouldn't?) have control of the status bar.
This can go on the discussion list.
</pre>
<br />
<p>- David</p>
<br />
<p>On February 4th, 2011, 12:43 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2011, 12:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use a proper KXmlGuiWindow and flexible structure.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/CMakeLists.txt <span style="color: grey">(86bea23)</span></li>
<li>app/chatwindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chatwindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chatwindow.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/main.cpp <span style="color: grey">(9ef06f9)</span></li>
<li>app/mainwindow.h <span style="color: grey">(badff27)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(54ac071)</span></li>
<li>app/telepathychatui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/telepathychatui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100547/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>