Review Request: port krdc and krfb to telepathy-qt4 0.5

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6441/#review9793
-----------------------------------------------------------


I thought the diff would be bigger, but good to see it's not. You should probably also change the FindTelepathyQt4.cmake files to look for the correct version of tp-qt4.

Now we need support for starting tubes in David's test contact list so that we can test it :)


trunk/KDE/kdenetwork/krdc/tubesmanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment10929>

    I wonder why you didn't change this ChannelClassList...



trunk/KDE/kdenetwork/krfb/krfb/tubesrfbserver.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment10928>

    this could also be Tp::Features


- George


On Feb. 2, 2011, 5:25 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6441/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 5:25 p.m.)
> 
> 
> Review request for telepathy.
> 
> 
> Summary
> -------
> 
> port krdc and krfb to telepathy-qt4 0.5 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approver.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tube.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.h 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesrfbserver.cpp 1218014 
> 
> Diff: http://svn.reviewboard.kde.org/r/6441/diff
> 
> 
> Testing
> -------
> 
> compiles against tp-qt4 master (02.02.2011), insuficient setup for testing the functionality atm.
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110202/c42c6259/attachment.htm