Review Request: port krdc and krfb to telepathy-qt4 0.5

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6441/#review9792
-----------------------------------------------------------


Only a few minor points. I would like to see this tested before it gets committed, maybe ask on the ML.


trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment10924>

    You can use spec.setChannelType, spec.setHandleType and spec.setRequested.
    here.



trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment10923>

    you can probably do dispatchOperation->channels();



trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp
<http://svn.reviewboard.kde.org/r/6441/#comment10926>

    You can use spec.setChannelType, spec.setHandleType and spec.setRequested.
    here.


- David


On Feb. 2, 2011, 5:25 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6441/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 5:25 p.m.)
> 
> 
> Review request for telepathy.
> 
> 
> Summary
> -------
> 
> port krdc and krfb to telepathy-qt4 0.5 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approver.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/krdc_approver/approvermanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tube.cpp 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.h 1218014 
>   trunk/KDE/kdenetwork/krdc/tubesmanager.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.h 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesclienthandler.cpp 1218014 
>   trunk/KDE/kdenetwork/krfb/krfb/tubesrfbserver.cpp 1218014 
> 
> Diff: http://svn.reviewboard.kde.org/r/6441/diff
> 
> 
> Testing
> -------
> 
> compiles against tp-qt4 master (02.02.2011), insuficient setup for testing the functionality atm.
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110202/05df0084/attachment-0001.htm