Review Request: Rename stuff in text-ui according to the new naming policy
Dario Freddi
drf at kde.org
Thu Dec 22 16:00:55 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103490/#review9169
-----------------------------------------------------------
Ship it!
Everything looks ok, except the CMake find file change. You can copy the new FindKTp.cmake from presence-applet
- Dario Freddi
On Dec. 21, 2011, 6:20 p.m., George Kiagiadakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103490/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2011, 6:20 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> http://community.kde.org/Real-Time_Communication_and_Collaboration/NamingPolicy
>
> I'm not sure about the ktp-chat-window-kcm.pot ...
>
>
> Diffs
> -----
>
> CMakeLists.txt f2a59adc7c1d49b5fbff6f9752edf2b85e7e7001
> adiumxtra-protocol-handler/CMakeLists.txt d0f25ae400bdc949529ea61484b43596cd8bde49
> adiumxtra-protocol-handler/Messages.sh f4723641d11f9f79ef0872597ca97e25d73106ca
> adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp 0502afbe5b9f78d6c1fab50e2834f980058259c8
> adiumxtra-protocol-handler/adiumxtra.protocol.in bea4f3192d9503786d6b3c511b2266f9d7c9533b
> adiumxtra-protocol-handler/chat-style-installer.cpp e43b179a55a073ef4f879c57f56c1ac0f469172a
> adiumxtra-protocol-handler/emoticon-set-installer.cpp 8a3685d2c95694ccb30f658e82b558f0dd6a2bc5
> adiumxtra-protocol-handler/main.cpp 2359418be0aff7660087fc8b3a478c61fb707a15
> app/CMakeLists.txt ae9f43bdbd372aba7bb0592e0714ffeb14ef87e3
> app/KDE.TextUi.client 0b0da88fdd40947e535b14b1557c928002656986
> app/KTp.TextUi.client PRE-CREATION
> app/Messages.sh ed451f51175091f530de09f23ae8d5f5b06bc4ba
> app/chat-tab.cpp 8ea95acbcdcc6a82b784a568a2d5f5030bf5d9ec
> app/chat-window.cpp 68f029583851117e7d9fd77402b60761c930b2bd
> app/chatwindow.rc c5b6496a27f28b8da41e5452e1ecbe523fdca3cb
> app/main.cpp ce607a96c634f9a7a1756f2221df8025f9a31aa9
> app/org.freedesktop.Telepathy.Client.KDE.TextUi.service.in d333f8bc152b9beda098374a1f3850b868af9955
> app/org.freedesktop.Telepathy.Client.KTp.TextUi.service.in PRE-CREATION
> config/CMakeLists.txt ba8031edc4eb635d05434247650808785a18a611
> config/Messages.sh 295f8a333acb3f5184439860728ca5e23b549fc1
> config/appearance-config.cpp a80fe751ae33e3168a09d7fedfb661268d0a033a
> config/behavior-config.cpp 65ddab91bea2eb427428de0b6d8900f11ba9c33f
> config/kcm_ktp_chat_appearance.desktop PRE-CREATION
> config/kcm_ktp_chat_behavior.desktop PRE-CREATION
> config/kcm_telepathy_chat_appearance_config.desktop 8140e03044bcadc26ec0d6edcf3d2397a78046f4
> config/kcm_telepathy_chat_behavior_config.desktop 7824fce923b4d68a03bb2b655ebe01ad948a8ef8
> lib/CMakeLists.txt 8ffc4946a38c55abd406cb17405702a5aa714dfc
> lib/KDETelepathy/AdiumThemeContentInfo 68aa6350ebbbec2857d1a251173995475120cd37
> lib/KDETelepathy/AdiumThemeHeaderInfo e8c8f6a85d6fb315e0629d227d3bf4037bbb4abb
> lib/KDETelepathy/AdiumThemeMessageInfo 922f4dca4feae1ef4d79d21ee9f22c5d07158317
> lib/KDETelepathy/AdiumThemeStatusInfo b0b9db4484bc8aea92210d5df2b7f57eed860752
> lib/KDETelepathy/AdiumThemeView a30f4cfa8ee74c4a05c97ccf89d085f04436ae6f
> lib/KDETelepathy/ChatStylePlistFileReader ed858b191e48d257170c48fdfe8ab2c20269faf3
> lib/KDETelepathy/ChatWidget 902ca640fa3d0f0df7832c5e64b47dbc43d1827b
> lib/KDETelepathy/ChatWindowStyle b434b07ff5a3f48a8ddf3b433b018afa31d383f3
> lib/KDETelepathy/ChatWindowStyleManager fbfb6e385e037220562738382dda62eb6e18cf78
> lib/KTp/AdiumThemeContentInfo PRE-CREATION
> lib/KTp/AdiumThemeHeaderInfo PRE-CREATION
> lib/KTp/AdiumThemeMessageInfo PRE-CREATION
> lib/KTp/AdiumThemeStatusInfo PRE-CREATION
> lib/KTp/AdiumThemeView PRE-CREATION
> lib/KTp/ChatStylePlistFileReader PRE-CREATION
> lib/KTp/ChatWidget PRE-CREATION
> lib/KTp/ChatWindowStyle PRE-CREATION
> lib/KTp/ChatWindowStyleManager PRE-CREATION
> lib/Messages.sh b307ad940728edbe34c7e5d92fa927e9da0a966d
> lib/adium-theme-content-info.h 59ef0533c7d0d1536bc1955b763f8a7a1b28b125
> lib/adium-theme-header-info.h 03f97346280f136f2915cdab5601d1a183b9b46f
> lib/adium-theme-message-info.h ddbead297b506234129f9ef51dcadc788fa5835a
> lib/adium-theme-status-info.h 884c82bc11e76d967d60d15aa59d567a36d28b86
> lib/adium-theme-view.h d42812cba94ab818610394013f88e668485f9dfc
> lib/chat-search-bar.h f5ae38446806201727e37e637bd0fa5403dcaa21
> lib/chat-style-plist-file-reader.h 23e4c465acd867cdbcd19473f9dc723bced4ba5f
> lib/chat-widget.h 82538162205293958fde8bd9e52b38c42c080248
> lib/chat-widget.cpp b55b81dfc1ee5503cb8c3cfc2dddf28f704a86dd
> lib/chat-window-style-manager.h 86bfe738866a97e8de2625bae480e6f3977242e1
> lib/chat-window-style.h b435382210cede63332dd6c6503a73433c23ecb3
> lib/kdetelepathychat_export.h ce5ce569c43f7163c4af4fa37847cfb52d0336e6
> lib/ktpchat_export.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/103490/diff/diff
>
>
> Testing
> -------
>
> I compiled it and verified the installed files are ok. Didn't try to run it.
>
>
> Thanks,
>
> George Kiagiadakis
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111222/f2d0e61e/attachment.html>
More information about the KDE-Telepathy
mailing list