<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103490/">http://git.reviewboard.kde.org/r/103490/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything looks ok, except the CMake find file change. You can copy the new FindKTp.cmake from presence-applet</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 21st, 2011, 6:20 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2011, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://community.kde.org/Real-Time_Communication_and_Collaboration/NamingPolicy
I'm not sure about the ktp-chat-window-kcm.pot ...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I compiled it and verified the installed files are ok. Didn't try to run it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f2a59adc7c1d49b5fbff6f9752edf2b85e7e7001)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: grey">(d0f25ae400bdc949529ea61484b43596cd8bde49)</span></li>
<li>adiumxtra-protocol-handler/Messages.sh <span style="color: grey">(f4723641d11f9f79ef0872597ca97e25d73106ca)</span></li>
<li>adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp <span style="color: grey">(0502afbe5b9f78d6c1fab50e2834f980058259c8)</span></li>
<li>adiumxtra-protocol-handler/adiumxtra.protocol.in <span style="color: grey">(bea4f3192d9503786d6b3c511b2266f9d7c9533b)</span></li>
<li>adiumxtra-protocol-handler/chat-style-installer.cpp <span style="color: grey">(e43b179a55a073ef4f879c57f56c1ac0f469172a)</span></li>
<li>adiumxtra-protocol-handler/emoticon-set-installer.cpp <span style="color: grey">(8a3685d2c95694ccb30f658e82b558f0dd6a2bc5)</span></li>
<li>adiumxtra-protocol-handler/main.cpp <span style="color: grey">(2359418be0aff7660087fc8b3a478c61fb707a15)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(ae9f43bdbd372aba7bb0592e0714ffeb14ef87e3)</span></li>
<li>app/KDE.TextUi.client <span style="color: grey">(0b0da88fdd40947e535b14b1557c928002656986)</span></li>
<li>app/KTp.TextUi.client <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/Messages.sh <span style="color: grey">(ed451f51175091f530de09f23ae8d5f5b06bc4ba)</span></li>
<li>app/chat-tab.cpp <span style="color: grey">(8ea95acbcdcc6a82b784a568a2d5f5030bf5d9ec)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(68f029583851117e7d9fd77402b60761c930b2bd)</span></li>
<li>app/chatwindow.rc <span style="color: grey">(c5b6496a27f28b8da41e5452e1ecbe523fdca3cb)</span></li>
<li>app/main.cpp <span style="color: grey">(ce607a96c634f9a7a1756f2221df8025f9a31aa9)</span></li>
<li>app/org.freedesktop.Telepathy.Client.KDE.TextUi.service.in <span style="color: grey">(d333f8bc152b9beda098374a1f3850b868af9955)</span></li>
<li>app/org.freedesktop.Telepathy.Client.KTp.TextUi.service.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(ba8031edc4eb635d05434247650808785a18a611)</span></li>
<li>config/Messages.sh <span style="color: grey">(295f8a333acb3f5184439860728ca5e23b549fc1)</span></li>
<li>config/appearance-config.cpp <span style="color: grey">(a80fe751ae33e3168a09d7fedfb661268d0a033a)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(65ddab91bea2eb427428de0b6d8900f11ba9c33f)</span></li>
<li>config/kcm_ktp_chat_appearance.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm_ktp_chat_behavior.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm_telepathy_chat_appearance_config.desktop <span style="color: grey">(8140e03044bcadc26ec0d6edcf3d2397a78046f4)</span></li>
<li>config/kcm_telepathy_chat_behavior_config.desktop <span style="color: grey">(7824fce923b4d68a03bb2b655ebe01ad948a8ef8)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(8ffc4946a38c55abd406cb17405702a5aa714dfc)</span></li>
<li>lib/KDETelepathy/AdiumThemeContentInfo <span style="color: grey">(68aa6350ebbbec2857d1a251173995475120cd37)</span></li>
<li>lib/KDETelepathy/AdiumThemeHeaderInfo <span style="color: grey">(e8c8f6a85d6fb315e0629d227d3bf4037bbb4abb)</span></li>
<li>lib/KDETelepathy/AdiumThemeMessageInfo <span style="color: grey">(922f4dca4feae1ef4d79d21ee9f22c5d07158317)</span></li>
<li>lib/KDETelepathy/AdiumThemeStatusInfo <span style="color: grey">(b0b9db4484bc8aea92210d5df2b7f57eed860752)</span></li>
<li>lib/KDETelepathy/AdiumThemeView <span style="color: grey">(a30f4cfa8ee74c4a05c97ccf89d085f04436ae6f)</span></li>
<li>lib/KDETelepathy/ChatStylePlistFileReader <span style="color: grey">(ed858b191e48d257170c48fdfe8ab2c20269faf3)</span></li>
<li>lib/KDETelepathy/ChatWidget <span style="color: grey">(902ca640fa3d0f0df7832c5e64b47dbc43d1827b)</span></li>
<li>lib/KDETelepathy/ChatWindowStyle <span style="color: grey">(b434b07ff5a3f48a8ddf3b433b018afa31d383f3)</span></li>
<li>lib/KDETelepathy/ChatWindowStyleManager <span style="color: grey">(fbfb6e385e037220562738382dda62eb6e18cf78)</span></li>
<li>lib/KTp/AdiumThemeContentInfo <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/AdiumThemeHeaderInfo <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/AdiumThemeMessageInfo <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/AdiumThemeStatusInfo <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/AdiumThemeView <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/ChatStylePlistFileReader <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/ChatWidget <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/ChatWindowStyle <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTp/ChatWindowStyleManager <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/Messages.sh <span style="color: grey">(b307ad940728edbe34c7e5d92fa927e9da0a966d)</span></li>
<li>lib/adium-theme-content-info.h <span style="color: grey">(59ef0533c7d0d1536bc1955b763f8a7a1b28b125)</span></li>
<li>lib/adium-theme-header-info.h <span style="color: grey">(03f97346280f136f2915cdab5601d1a183b9b46f)</span></li>
<li>lib/adium-theme-message-info.h <span style="color: grey">(ddbead297b506234129f9ef51dcadc788fa5835a)</span></li>
<li>lib/adium-theme-status-info.h <span style="color: grey">(884c82bc11e76d967d60d15aa59d567a36d28b86)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(d42812cba94ab818610394013f88e668485f9dfc)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(f5ae38446806201727e37e637bd0fa5403dcaa21)</span></li>
<li>lib/chat-style-plist-file-reader.h <span style="color: grey">(23e4c465acd867cdbcd19473f9dc723bced4ba5f)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(82538162205293958fde8bd9e52b38c42c080248)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(b55b81dfc1ee5503cb8c3cfc2dddf28f704a86dd)</span></li>
<li>lib/chat-window-style-manager.h <span style="color: grey">(86bfe738866a97e8de2625bae480e6f3977242e1)</span></li>
<li>lib/chat-window-style.h <span style="color: grey">(b435382210cede63332dd6c6503a73433c23ecb3)</span></li>
<li>lib/kdetelepathychat_export.h <span style="color: grey">(ce5ce569c43f7163c4af4fa37847cfb52d0336e6)</span></li>
<li>lib/ktpchat_export.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103490/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>