Review Request: Don't crash on multi user chat

Dominik Cermak d.cermak at arcor.de
Sat Dec 17 11:50:49 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103437/
-----------------------------------------------------------

(Updated Dec. 17, 2011, 11:50 a.m.)


Review request for Telepathy.


Changes
-------

Moved after the assert and use otherContact.


Description
-------

Don't crash on multi user chat.
Move the call to targetContact() in the block for normal chat because it can't be used with a targetHandleType() != Contact.


Diffs (updated)
-----

  lib/chat-widget.cpp dbac767a81e0d574f2b7b54794d9b2e907ebbcf0 

Diff: http://git.reviewboard.kde.org/r/103437/diff/diff


Testing
-------

Text-ui doesn't crash after joining a MUC.


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111217/2f9dc17e/attachment.html>


More information about the KDE-Telepathy mailing list