Review Request: Don't crash on multi user chat

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103437/#review9022
-----------------------------------------------------------

Ship it!


Good spot, make sure to tell Martin off for committing code that crashes.

Minor change to make before committing. 


lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103437/#comment7471>

    move this to just after the assert and user otherContact->alias();
    it'll read cleaner, and otherwise you ruin the point of the assert.


- David Edmundson


On Dec. 17, 2011, 10:31 a.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103437/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2011, 10:31 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Don't crash on multi user chat.
> Move the call to targetContact() in the block for normal chat because it can't be used with a targetHandleType() != Contact.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp dbac767a81e0d574f2b7b54794d9b2e907ebbcf0 
> 
> Diff: http://git.reviewboard.kde.org/r/103437/diff/diff
> 
> 
> Testing
> -------
> 
> Text-ui doesn't crash after joining a MUC.
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111217/4a898d5c/attachment.html>