Review Request: Add names to tooltip KActions.

Martin Klapetek martin.klapetek at gmail.com
Fri Aug 26 13:30:58 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102303/#review6028
-----------------------------------------------------------


Patch is ok, although I'd rather see it implementing KToggleActions for the sort button and perhaps show/hide groups button too -- https://bugs.kde.org/show_bug.cgi?id=279106 -- can you update it with KToggleActions so we can squash two things with one patch?


main-widget.cpp
<http://git.reviewboard.kde.org/r/102303/#comment5313>

    This lonely line can now be removed.


- Martin


On Aug. 11, 2011, 10:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102303/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 10:46 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add names to the actions in the tooltips.
> Set tooltip style to not show the text. This visually looks the same, but means we can re-use the actions in menus and probably helps accesibility.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp d353db0e670e0cd1af29c2d0401c0d8d4a509f00 
> 
> Diff: http://git.reviewboard.kde.org/r/102303/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110826/df9d25d6/attachment.html>


More information about the KDE-Telepathy mailing list