Review Request: Do not use the Tp::AbstractClientHandler to control when ft-handler should exit

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu Aug 11 14:31:09 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102306/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Summary
-------

To handle metadata we will need another Tp::AbstactClientHandler for streamtubes, therefore it's not good to use the FileTransferHandler class to control the whole program

This patch adds a new class (FileTransferControl) that works almost like a singleton (without using K_GLOBAL_STATIC that doesn't work for QObjects) and moves control of the flow of the program into this class.


Diffs
-----

  src/CMakeLists.txt 9e84a8b9d427505a8babc79713ca41f1ec223a2a 
  src/filetransfer-control.h PRE-CREATION 
  src/filetransfer-control.cpp PRE-CREATION 
  src/filetransfer-handler.h 6fd6c4b19859ea41f50caec48699253b8fe6b0be 
  src/filetransfer-handler.cpp 0e4624e46b4a702afa962dc3efcff37d4dae54ff 
  src/main.cpp c8c52d356afe378d8839175b1f88e311b42955e6 

Diff: http://git.reviewboard.kde.org/r/102306/diff


Testing
-------

Tried file transfers (just on my laptop) still exits when it is supposed to exit.


Thanks,

Daniele Elmo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110811/e4f674bd/attachment.html>


More information about the KDE-Telepathy mailing list