Review Request: Proper profile support in ParameterModel

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101186/#review2858
-----------------------------------------------------------

Ship it!


Looks good, minor nitpick I'd like to see fixed before committing.

P.S.: If you can, try and put the code style fixes in a separate commit


src/KCMTelepathyAccounts/parameter-edit-model.cpp
<http://git.reviewboard.kde.org/r/101186/#comment2486>

    Watch out for spaces, and remember to const'ify:
    foreach (const Tp::Profile::Parameter &profileParameter, profileparameters)


- Dario


On April 23, 2011, 12:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101186/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 12:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Updated parameter edit model to keep track of profile parameters
> Removed work around that set default value on first creation based on profile parameter.
> 
> Disable non-editable edit fields where the value comes from a profile
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp d28b4f3fed227aa2b15342f4b9312c02b8babea9 
>   src/KCMTelepathyAccounts/parameter-edit-model.h ecd04e7b2aa7670a89b5fbf264c177df27c9057b 
>   src/KCMTelepathyAccounts/parameter-edit-model.cpp 441b6e58daf13b3fcf65ab344544ae36e50b940b 
>   src/KCMTelepathyAccounts/parameter-item.h 047aa57a6c8499b9e2619dc5b9b4f6bdc483ef6a 
>   src/KCMTelepathyAccounts/parameter-item.cpp c7d827ab923c302a8942bd75c276118f8f19882a 
>   src/add-account-assistant.cpp e038e8bf3256c2e99f755fdc0dd2945117833c91 
>   src/edit-account-dialog.cpp bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9 
> 
> Diff: http://git.reviewboard.kde.org/r/101186/diff
> 
> 
> Testing
> -------
> 
> Created a Facebook account, made sure defaults were filled in, and are now greyed out (disabled) for server/port.
> A normal jabber account has no defaults and is all editable.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110424/9b98711b/attachment.htm