<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101186/">http://git.reviewboard.kde.org/r/101186/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, minor nitpick I'd like to see fixed before committing.
P.S.: If you can, try and put the code style fixes in a separate commit</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101186/diff/1/?file=15199#file15199line218" style="color: black; font-weight: bold; text-decoration: underline;">src/KCMTelepathyAccounts/parameter-edit-model.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Tp::ProtocolParameter ParameterEditModel::parameter(const QString &parameterName) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">218</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="n">Tp</span><span class="o">::</span><span class="n">Profile</span><span class="o">::</span><span class="n">Parameter</span> <span class="n">profileParameter</span><span class="p">,</span> <span class="n">profileParameters</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Watch out for spaces, and remember to const'ify:
foreach (const Tp::Profile::Parameter &profileParameter, profileparameters)</pre>
</div>
<br />
<p>- Dario</p>
<br />
<p>On April 23rd, 2011, 12:11 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 23, 2011, 12:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated parameter edit model to keep track of profile parameters
Removed work around that set default value on first creation based on profile parameter.
Disable non-editable edit fields where the value comes from a profile
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created a Facebook account, made sure defaults were filled in, and are now greyed out (disabled) for server/port.
A normal jabber account has no defaults and is all editable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(d28b4f3fed227aa2b15342f4b9312c02b8babea9)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(ecd04e7b2aa7670a89b5fbf264c177df27c9057b)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(441b6e58daf13b3fcf65ab344544ae36e50b940b)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.h <span style="color: grey">(047aa57a6c8499b9e2619dc5b9b4f6bdc483ef6a)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.cpp <span style="color: grey">(c7d827ab923c302a8942bd75c276118f8f19882a)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(e038e8bf3256c2e99f755fdc0dd2945117833c91)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101186/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>