Review Request: Simplifying the pin/unpin mechanism of the filter bar

Rémy Greinhofer remy.greinhofer at gmail.com
Sat Apr 23 13:38:52 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101190/
-----------------------------------------------------------

(Updated April 23, 2011, 11:38 a.m.)


Review request for Telepathy.


Changes
-------

Changed according to the previous remark.


Summary
-------

After second though, we decided a button to pin/unpin the filter bar was not necessary. The filter bar will simply be shown if it was when the contact list was closed and vice-versa.


Diffs (updated)
-----

  filter-bar.h 2acb724 
  filter-bar.cpp 1d04ca8 
  main-widget.cpp 4b877ab 

Diff: http://git.reviewboard.kde.org/r/101190/diff


Testing
-------

1. Use the filter bar, close the contact list, relaunch the contact list. The filter bar is shown.
2. Then close the filter bar, close the contact list, relaunch the contact list. The filter bar disappeared.

It works if you use the close button of the filter bar, as well as the search contact button.


Thanks,

Rémy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110423/c8691642/attachment-0001.htm 


More information about the KDE-Telepathy mailing list