Review Request: Simplifying the pin/unpin mechanism of the filter bar

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101190/#review2842
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/101190/#comment2482>

    I don't think you need to go via a string here
    
    if(configGroup.readEntry("pin_filterbar", false))
    
    by supplying a default it knows the type is boolean and I think it will just give you the correct true/false.
    


- David


On April 23, 2011, 10:32 a.m., Rémy Greinhofer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101190/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 10:32 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> After second though, we decided a button to pin/unpin the filter bar was not necessary. The filter bar will simply be shown if it was when the contact list was closed and vice-versa.
> 
> 
> Diffs
> -----
> 
>   filter-bar.h 2acb724 
>   filter-bar.cpp 1d04ca8 
>   main-widget.cpp 4b877ab 
> 
> Diff: http://git.reviewboard.kde.org/r/101190/diff
> 
> 
> Testing
> -------
> 
> 1. Use the filter bar, close the contact list, relaunch the contact list. The filter bar is shown.
> 2. Then close the filter bar, close the contact list, relaunch the contact list. The filter bar disappeared.
> 
> It works if you use the close button of the filter bar, as well as the search contact button.
> 
> 
> Thanks,
> 
> Rémy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110423/5914f9fc/attachment.htm