Review Request: Add profile files to AccountsKCM

[Olli Salli]

> On April 23, 2011, 7:38 a.m., Martin Klapetek wrote:
> > data/profiles/google-talk.profile, lines 19-21
> > <http://git.reviewboard.kde.org/r/101183/diff/1/?file=15172#file15172line19>
> >
> >     I'm not sure what the exact meaning of this block is, but why is there only one icon (for the online)? 
> >     
> >     Also, does this mean it will support only these presences? Because I'd thought GTalk supports more presences.

The allow-others=1 in the immediately preceding line means "the other presences are available". However, I believe that for Facebook allow-others should actually be 0 - as there are no other statuses in Facebook, right? Also, you could add the info that Facebook doesn't allow you to set the status message using the XMPP API with the message=0 attribute for each Facebook presence.


> On April 23, 2011, 7:38 a.m., Martin Klapetek wrote:
> > data/profiles/irc.profile, line 7
> > <http://git.reviewboard.kde.org/r/101183/diff/1/?file=15173#file15173line7>
> >
> >     We could add a default irc server values (but still editable), freenode perhaps?

The different IRC networks are different services, so you should have a freenode.profile, gimpnet.profile, oftc.profile etc. Similarly for SIP you should probably have different profiles for common SIP services, e.g. ekiga.net, rather than specifying one of them as a "default" in a single SIP profile.


> On April 23, 2011, 7:38 a.m., Martin Klapetek wrote:
> > data/profiles/msn.profile, line 7
> > <http://git.reviewboard.kde.org/r/101183/diff/1/?file=15176#file15176line7>
> >
> >     Does MSN have some standard values for server, port etc?

These should come from the CM .manager file info (accessed in TpQt4 via the fake profile, or directly via the ConnectionManager ProtocolInfo API). You shouldn't duplicate them here.

Similarly, I believe Idle specifies a default port of 6667: it's correct that we don't duplicate it here.


- Olli


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101183/#review2835
-----------------------------------------------------------


On April 22, 2011, 10:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101183/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 10:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add profile files to AccountsKCM
> 
> 
> Diffs
> -----
> 
>   data/profiles/irc.profile PRE-CREATION 
>   data/profiles/jabber.profile PRE-CREATION 
>   data/profiles/local-xmpp.profile PRE-CREATION 
>   data/profiles/msn.profile PRE-CREATION 
>   data/profiles/sofiasip-sip.profile PRE-CREATION 
>   CMakeLists.txt 5a2af5f5428596f52327932b4fa0603d163cb58f 
>   data/CMakeLists.txt PRE-CREATION 
>   data/profiles/facebook.profile PRE-CREATION 
>   data/profiles/google-talk.profile PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101183/diff
> 
> 
> Testing
> -------
> 
> Created a new Facebook and GMail account. Defaults were filled in, and worked correctly.
> 
> This experience was far from perfect, but that is a set of other bugs in other code.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110423/fde01168/attachment.htm