Review Request: Add profile files to AccountsKCM

Martin Klapetek martin.klapetek at gmail.com
Sat Apr 23 09:38:49 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101183/#review2835
-----------------------------------------------------------

Ship it!


Finally we have GTalk and Facebook back!


data/profiles/google-talk.profile
<http://git.reviewboard.kde.org/r/101183/#comment2476>

    I'm not sure what the exact meaning of this block is, but why is there only one icon (for the online)? 
    
    Also, does this mean it will support only these presences? Because I'd thought GTalk supports more presences.



data/profiles/irc.profile
<http://git.reviewboard.kde.org/r/101183/#comment2477>

    We could add a default irc server values (but still editable), freenode perhaps?



data/profiles/msn.profile
<http://git.reviewboard.kde.org/r/101183/#comment2478>

    Does MSN have some standard values for server, port etc?


- Martin


On April 22, 2011, 10:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101183/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 10:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add profile files to AccountsKCM
> 
> 
> Diffs
> -----
> 
>   data/profiles/irc.profile PRE-CREATION 
>   data/profiles/jabber.profile PRE-CREATION 
>   data/profiles/local-xmpp.profile PRE-CREATION 
>   data/profiles/msn.profile PRE-CREATION 
>   data/profiles/sofiasip-sip.profile PRE-CREATION 
>   CMakeLists.txt 5a2af5f5428596f52327932b4fa0603d163cb58f 
>   data/CMakeLists.txt PRE-CREATION 
>   data/profiles/facebook.profile PRE-CREATION 
>   data/profiles/google-talk.profile PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101183/diff
> 
> 
> Testing
> -------
> 
> Created a new Facebook and GMail account. Defaults were filled in, and worked correctly.
> 
> This experience was far from perfect, but that is a set of other bugs in other code.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110423/586e0e9b/attachment-0001.htm 


More information about the KDE-Telepathy mailing list