Review Request: Misc Tiny Fixes in Text-Ui

Martin Klapetek martin.klapetek at gmail.com
Sun Apr 10 12:08:43 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101060/#review2537
-----------------------------------------------------------

Ship it!


Just two small whitespace leftovers..


lib/chat-widget.h
<http://git.reviewboard.kde.org/r/101060/#comment2225>

    You missed one & here ;) (Tp::ContactPtr &contact)



lib/chat-widget.h
<http://git.reviewboard.kde.org/r/101060/#comment2226>

    Same as above


- Martin


On April 8, 2011, 12:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101060/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 12:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Made sure all destructors are virtual
> Tidied up some includes/whitespace
> Converted from KApplication->KUniqueApplication.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 8dd39009a8009ab3983e0eef802aff83ab29f95d 
>   app/telepathy-chat-ui.h 3d2001588a073215fe90d3816d5b9ab8c3cd2144 
>   app/telepathy-chat-ui.cpp 5473394ef4020bf4f02f304296df9214a18d988a 
>   config/main-window.cpp 21bce19cf1fc8530bf457b0f808cf4df93d5d664 
>   lib/adium-theme-content-info.h d91ebd664613cdaf2d895be46e8f218d32e16221 
>   lib/adium-theme-header-info.h da25633a8b4b86f2b88ae35a1d8c7b61a5172e11 
>   lib/adium-theme-message-info.h 97d93525d018a99e723589377430d51e33e1ffe3 
>   lib/adium-theme-status-info.h 05a4193be40791f324b8cb557562c37c7eb69899 
>   lib/adium-theme-view.h 920e06208ea7f6cef23054c4a1ddf52ed02aa420 
>   lib/adium-theme-view.cpp abcfd7d26b6704cc5b9e5f9294c7d4827d2f7676 
>   lib/chat-search-bar.h PRE-CREATION 
>   lib/chat-widget.h dfdef64fcbebb727709f8492b4e558503ce32759 
>   lib/chat-window-style-manager.h b07b4c26413bcd014f4b6e4f135ffcea0b2a3589 
>   lib/chat-window-style.h 3ca12a8a00b406ba0bf79af4ec4baab86d853ba5 
> 
> Diff: http://git.reviewboard.kde.org/r/101060/diff
> 
> 
> Testing
> -------
> 
> Still compiles.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110410/f7523d22/attachment.htm 


More information about the KDE-Telepathy mailing list