<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101060/">http://git.reviewboard.kde.org/r/101060/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just two small whitespace leftovers..</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101060/diff/1/?file=14017#file14017line89" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-widget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">onContactPresenceChange</span><span class="p">(</span><span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ContactPtr</span> <span class="o">&</span> <span class="n">contact</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">Presence</span> <span class="o">&</span> <span class="n">presence</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">onContactPresenceChange</span><span class="p">(</span><span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ContactPtr</span> <span class="o">&</span> <span class="n">contact</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">Presence</span> <span class="o">&</span><span class="n">presence</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You missed one & here ;) (Tp::ContactPtr &contact)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101060/diff/1/?file=14017#file14017line91" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-widget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">onContactAliasChanged</span><span class="p">(</span><span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ContactPtr</span> <span class="o">&</span> <span class="n">contact</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="n">alias</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">onContactAliasChanged</span><span class="p">(</span><span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ContactPtr</span> <span class="o">&</span> <span class="n">contact</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">alias</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same as above</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On April 8th, 2011, 12:38 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 8, 2011, 12:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made sure all destructors are virtual
Tidied up some includes/whitespace
Converted from KApplication->KUniqueApplication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/main.cpp <span style="color: grey">(8dd39009a8009ab3983e0eef802aff83ab29f95d)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(3d2001588a073215fe90d3816d5b9ab8c3cd2144)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(5473394ef4020bf4f02f304296df9214a18d988a)</span></li>
<li>config/main-window.cpp <span style="color: grey">(21bce19cf1fc8530bf457b0f808cf4df93d5d664)</span></li>
<li>lib/adium-theme-content-info.h <span style="color: grey">(d91ebd664613cdaf2d895be46e8f218d32e16221)</span></li>
<li>lib/adium-theme-header-info.h <span style="color: grey">(da25633a8b4b86f2b88ae35a1d8c7b61a5172e11)</span></li>
<li>lib/adium-theme-message-info.h <span style="color: grey">(97d93525d018a99e723589377430d51e33e1ffe3)</span></li>
<li>lib/adium-theme-status-info.h <span style="color: grey">(05a4193be40791f324b8cb557562c37c7eb69899)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(920e06208ea7f6cef23054c4a1ddf52ed02aa420)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(abcfd7d26b6704cc5b9e5f9294c7d4827d2f7676)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(dfdef64fcbebb727709f8492b4e558503ce32759)</span></li>
<li>lib/chat-window-style-manager.h <span style="color: grey">(b07b4c26413bcd014f4b6e4f135ffcea0b2a3589)</span></li>
<li>lib/chat-window-style.h <span style="color: grey">(3ca12a8a00b406ba0bf79af4ec4baab86d853ba5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>