Review Request: Add a option to let the user go online as soon as the wizard exits

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101031/#review2404
-----------------------------------------------------------

Ship it!


Near perfect. 
Keep watching out for putting in the curly brackets on all your if statements.
Please fix before merging.


src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/101031/#comment2065>

    you can lose the m_ prefix now
    
    as you access it from the private class it's obvious it's a member variable.



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/101031/#comment2064>

    braces {}



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/101031/#comment2062>

    braces
    
    if (foo) {
    
    }



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/101031/#comment2063>

    braces
    


- David


On April 5, 2011, 4:18 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101031/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 4:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add a option to let the user go online with his new account as soon as he adds it.
> 
> 
> This addresses bug 269911.
>     http://bugs.kde.org/show_bug.cgi?id=269911
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/account-edit-widget.h 8e0c7ea 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp 5c09e5d 
>   src/add-account-assistant.cpp e038e8b 
>   src/edit-account-dialog.cpp 2772c61 
> 
> Diff: http://git.reviewboard.kde.org/r/101031/diff
> 
> 
> Testing
> -------
> 
> Patch compiles and works as described above, i could see my account go online as soon as i added it, and when the tick box was unchecked, the account did not connect
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101031/s/112/
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110405/8277a28f/attachment-0001.htm