Review Request: Add a option to let the user go online as soon as the wizard exits
Rohan Garg
rohangarg at kubuntu.org
Tue Apr 5 18:18:47 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101031/
-----------------------------------------------------------
(Updated April 5, 2011, 4:18 p.m.)
Review request for Telepathy.
Changes
-------
Handle null pointers and move the checkbox into AccountEditWidget::Private in order to maintain binary compatibility
Summary
-------
Add a option to let the user go online with his new account as soon as he adds it.
This addresses bug 269911.
http://bugs.kde.org/show_bug.cgi?id=269911
Diffs (updated)
-----
src/KCMTelepathyAccounts/account-edit-widget.h 8e0c7ea
src/KCMTelepathyAccounts/account-edit-widget.cpp 5c09e5d
src/add-account-assistant.cpp e038e8b
src/edit-account-dialog.cpp 2772c61
Diff: http://git.reviewboard.kde.org/r/101031/diff
Testing
-------
Patch compiles and works as described above, i could see my account go online as soon as i added it, and when the tick box was unchecked, the account did not connect
Screenshots
-----------
http://git.reviewboard.kde.org/r/101031/s/112/
Thanks,
Rohan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110405/ee2d5d71/attachment.htm
More information about the KDE-Telepathy
mailing list