Review Request: Implement the Main/Advanced option split scheme in the telepathy-accounts-kcm

[Gustavo Boiko]

> On 2010-09-29 21:08:45, George Goldberg wrote:
> > This is getting closer to getting a "Ship It", but still it is not quite ready.
> > 
> > Everything now compiles nicely, but I'm still finding bugs on testing:
> > 
> > 1) Click on "Edit" on an existing account and there are two problems:
> >   a) nitpick: there is an unusually large gap between the bottom of the widget displaying the parameters and the OK/Cancel buttons at the bottom.
> >   b) less-of-a-nitpick: when I click on "OK" button, nothing happens - the dialog stays open and there is no feedback as to why.
> > 
> > 2) Click on "Add", then select any protocol.
> >   a) The parameters widget only takes up half of the available space in the dialog leaving a large empty space.
> >   b) If I fail to fill in all the mandatory parameters and click OK, the dialog remains but there is no feedback in the UI as to why it didn't work.

About the layout problems, I'm not worrying about that right now, as the face of the dialogs will probably change, the important step now is to get the base well defined.

The not-closing-dialog problem is already fixed.

The widget not having feedback is probably a problem that was already there, or at least I fail to find what could have caused that. As I will continue working on the kcm, I will fix that in a separate commit.


- Gustavo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5467/#review7892
-----------------------------------------------------------


On 2010-09-29 12:58:50, Gustavo Boiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5467/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 12:58:50)
> 
> 
> Review request for telepathy.
> 
> 
> Summary
> -------
> 
> This patch implements the config scheme discussed in the mailing list. The account edit dialog now shows only one dialog containing all the main options for the protocol, and optionally an advanced button which opens one second dialog containing extra options.
> 
> There is no more distinction between mandatory and optional arguments, but the dialog ensures all mandatory arguments are handle, falling back to a generic dialog if they are not.
> 
> The patch also simplifies the loading of configuration widgets by creating the AccountEditDialog, which does all the job of loading the dialogs. This dialog is used by both the EditAccountDialog and the AddAccountWizard. It will also be used in the Kopete Telepathy plugin (I will work on this right after this one gets in).
> 
> The port of the plugins to this new scheme is already being done.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.h 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.cpp 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/CMakeLists.txt 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.h 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.cpp 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.h PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.cpp PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.ui PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/AccountEditWidget PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/MandatoryParameterEditWidget 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/OptionalParameterEditWidget 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.cpp 1179066 
> 
> Diff: http://svn.reviewboard.kde.org/r/5467/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gustavo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20100930/0386934a/attachment-0001.htm