Review Request: adiumxtra-protocol-handler: supporting chat styles and emoticons

[Dominik Schmidt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5483/
-----------------------------------------------------------

Review request for telepathy.


Summary
-------

The main.cpp is a little hacky.

Should I subclass KApplication and put the install function there?
This would avoid the global app pointer and I could then add a slot displaySuccess() or something which would then show a knotification.
Other suggestions how to solve this?


If you want to test it, just go to http://www.adiumxtras.com and click an install link for chat styles or emoticons. It's broken in KDE (at least) trunk though :-( 
You can test it simply this way:
adiumxtra-protocol-handler adiumxtra://www.adiumxtras.com/download/2463 (for Gone Dark theme)
adiumxtra-protocol-handler adiumxtra://www.adiumxtras.com/download/4058 (for cool_cat emoticon theme)


Diffs
-----

  /trunk/playground/network/telepathy-chat-handler/lib/chatwindowstylemanager.cpp 1180207 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/emoticonsetinstaller.h PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/emoticonsetinstaller.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/main.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.h 1180207 
  /trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.cpp 1180207 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/chatstyleinstaller.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/chatstyleinstaller.h PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/CMakeLists.txt 1180207 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/CMakeLists.txt PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/adiumxtra-protocol-handler.notifyrc PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/adiumxtra.protocol PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/bundleinstaller.h PRE-CREATION 
  /trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/bundleinstaller.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5483/diff


Testing
-------

Yes, works for me :-)


Screenshots
-----------

Chatstyle Installation
  http://svn.reviewboard.kde.org/r/5483/s/514/
Emoticonset Installation
  http://svn.reviewboard.kde.org/r/5483/s/515/


Thanks,

Dominik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20100929/aac93b6f/attachment.htm