Review Request: Make the dialogs modal and set the config page titles in a simpler (and more flexible) way

[Gustavo Boiko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5423/
-----------------------------------------------------------

Review request for telepathy.


Summary
-------

This patch unfortunatelly does basically three things:
- Make both the add account wizard and the edit account dialog modals, meaning that the parent dialog will only be accessible if the adding or the editting operation is finished (which is the default behavior of dialogs like that).
- Set the config pages' titles using the windowTitle property from the pages themselves (this is more flexible as new k-t-a plugins won' t require changes in the the kcm module itself
- Put the edit dialog creation resposibility on the kcm module itself, avoiding all those parent() calls in the account item

The patch also fixes the bug indicated in this request, but it is just a side effect of the above changes


This addresses bug 252053.
    https://bugs.kde.org/show_bug.cgi?id=252053


Diffs
-----

  /trunk/playground/network/telepathy-accounts-kcm/src/account-item.h 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/account-item.cpp 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/accounts-list-model.h 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/accounts-list-model.cpp 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.h 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.h 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.cpp 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/kcm-telepathy-accounts.h 1178368 
  /trunk/playground/network/telepathy-accounts-kcm/src/kcm-telepathy-accounts.cpp 1178368 

Diff: http://svn.reviewboard.kde.org/r/5423/diff


Testing
-------


Thanks,

Gustavo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20100923/37250f1b/attachment.htm