<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5423/">http://svn.reviewboard.kde.org/r/5423/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for telepathy.</div>
<div>By Gustavo Boiko.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch unfortunatelly does basically three things:
- Make both the add account wizard and the edit account dialog modals, meaning that the parent dialog will only be accessible if the adding or the editting operation is finished (which is the default behavior of dialogs like that).
- Set the config pages' titles using the windowTitle property from the pages themselves (this is more flexible as new k-t-a plugins won' t require changes in the the kcm module itself
- Put the edit dialog creation resposibility on the kcm module itself, avoiding all those parent() calls in the account item
The patch also fixes the bug indicated in this request, but it is just a side effect of the above changes</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=252053">252053</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/playground/network/telepathy-accounts-kcm/src/account-item.h <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/account-item.cpp <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/accounts-list-model.h <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/accounts-list-model.cpp <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.h <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.h <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.cpp <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/kcm-telepathy-accounts.h <span style="color: grey">(1178368)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/kcm-telepathy-accounts.cpp <span style="color: grey">(1178368)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5423/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>