Review Request: Make q_ptr protected in TelepathyBaseJobPrivate and use it in subclasses

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4153/#review5873
-----------------------------------------------------------


Thanks for the change. One minor annotation which applies to every constructor you have changed.


/trunk/playground/network/telepathy-contactlist/add-contact-job.cpp
<http://reviewboard.kde.org/r/4153/#comment5499>

    initializing q_ptr should not be needed (please test though), as it is already initialized by the base class. So you're initializing it two times - removing this declaration should make it work fine.


- Dario


On 2010-05-26 08:59:47, Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4153/
> -----------------------------------------------------------
> 
> (Updated 2010-05-26 08:59:47)
> 
> 
> Review request for telepathy and Dario Freddi.
> 
> 
> Summary
> -------
> 
> q_ptr is declared private in TelepathyBaseJobPrivate, but it should be protected.
> Derived classes should use the same q_ptr and not declare another one.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-contactlist/add-contact-job.cpp 1130253 
>   /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.cpp 1130253 
>   /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.cpp 1130253 
>   /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.cpp 1130253 
>   /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp 1130253 
>   /trunk/playground/network/telepathy-contactlist/telepathy-base-job_p.h 1130253 
> 
> Diff: http://reviewboard.kde.org/r/4153/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E.
> 
>