Review Request: Make q_ptr protected in TelepathyBaseJobPrivate and use it in subclasses

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Wed May 26 10:59:48 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4153/
-----------------------------------------------------------

Review request for telepathy and Dario Freddi.


Summary
-------

q_ptr is declared private in TelepathyBaseJobPrivate, but it should be protected.
Derived classes should use the same q_ptr and not declare another one.


Diffs
-----

  /trunk/playground/network/telepathy-contactlist/add-contact-job.cpp 1130253 
  /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.cpp 1130253 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.cpp 1130253 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.cpp 1130253 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp 1130253 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job_p.h 1130253 

Diff: http://reviewboard.kde.org/r/4153/diff


Testing
-------


Thanks,

Daniele E.



More information about the KDE-Telepathy mailing list