Review Request: Add Telepathy capabilities to tp-contactlist, and enable removing/adding contacts from/to a group, and removing/adding contacts

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3415/
-----------------------------------------------------------

(Updated 2010-03-30 10:42:54.549238)


Review request for telepathy and George Goldberg.


Changes
-------

Updated description and summary


Summary (updated)
-------

This patch adds three new classes and a variety of jobs (already ready to be librarized) for creating a Nepomuk->Telepathy bridge, making it very easy to access Tp-qt4 functions from clients using Nepomuk. Performance overhead looks trascurable.

By using this new class, contactlist is now able to add/remove people from a group, and adding/removing contacts. Metacontacts are still work in progress, but should not be a big deal.

Error handling is implemented library-side.

Everything which is not in the new classes is mostly a proof of concept, which will be refined as soon as this patch will make it in.

Beware: until t-i-d will be able to catch these changes and update nepomuk accordingly, this is probably going to screw up your nepomuk DB when moving contacts around groups.


Diffs
-----

  /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1107773 
  /trunk/playground/network/telepathy-contactlist/add-contact-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contact-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/contact-item.h 1107996 
  /trunk/playground/network/telepathy-contactlist/contact-item.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.h 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.ui 1107667 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1107996 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job_p.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge_p.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3415/diff


Testing
-------

Works, empathy recognizes the changes correctly.


Thanks,

Dario