[Bug 293886] Contact list crash while wheeling as a foul on top of a contact 'Start a duscution' mini icon

Martin Klapetek martin.klapetek at gmail.com
Sat May 12 14:55:02 BST 2012


https://bugs.kde.org/show_bug.cgi?id=293886

Martin Klapetek <martin.klapetek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-contact-list/8348dda8
                   |                            |de679adc91ff3ea63a34b0221d0
                   |                            |e7978

--- Comment #3 from Martin Klapetek <martin.klapetek at gmail.com> ---
Git commit 8348dda8de679adc91ff3ea63a34b0221d0e7978 by Martin Klapetek.
Committed on 12/05/2012 at 15:50.
Pushed by mklapetek into branch 'master'.

Make the delegate overlays code signicitantly simpler, fixes crash in the
process

The overlays were in several classes, all deriving one from another. This
commit merges several of the classes into one and removes unused and/or useless
methods, thus simplifying the code and making it more readable, effective and
easier to maintain.

Reviewed-by: David Edmundson
REVIEW: 104887

M  +82   -190  contact-delegate-overlay.cpp
M  +40   -125  contact-delegate-overlay.h
M  +4    -1    contact-delegate.cpp
M  +2    -14   contact-list-widget.cpp
M  +11   -11   contact-overlays.cpp
M  +7    -8    contact-overlays.h
M  +3    -3    contact-view-hover-button.cpp
M  +5    -11   contact-view-hover-button.h

http://commits.kde.org/telepathy-contact-list/8348dda8de679adc91ff3ea63a34b0221d0e7978

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kde-telepathy-bugs mailing list