[Kde-scm-interest] Post-commit hooks script

[Jean-Nicolas Artaud]

Le samedi 05 décembre 2009 12:11:19 AM, Oswald Buddenhagen a écrit :
> On Fri, Dec 04, 2009 at 07:49:52PM +0100, Jean-Nicolas Artaud wrote:
> >     # One mail send for each CCMAIL
> >     for myMail in email_addresses
> >         mailIo = IO.popen("/usr/sbin/sendmail #{myMail}", 'w')
> 
> that's a bad idea. for one, each mesage has a separate message id, which
> makes duplicate elimination not work. second, spawning a separate
> sendmail for each mail is wasting resources.
> 
> as you are ignoring refs other than the currently updated one, you'll
> re-send all mails when a branch from the same repo is merged.
> you are entirely ignoring the existence of new refs, which will lead to
> kinda interesting effects when someone creates a bugfix branch.
Johannes had already explained to me in private. He gives me tips, I will use 
them to have something working and right ASAP. We'll just take yourse when it 
will be ready : it will surely be better than mine and waste less ressources.

> 
> quite frankly, you did the trivial work. you can either do the hard
> stuff and spend a lot of time on it or just wait for me to finish -
> there are enough other things to do, and i'll do my script anyway, as i
> a) need it for another project and b) want something generic for
> submission to git upstream.
Ok perfect, once done we'll use it of course. Thank you for the answer btw.

> _______________________________________________
> Kde-scm-interest mailing list
> Kde-scm-interest at kde.org
> https://mail.kde.org/mailman/listinfo/kde-scm-interest
> 

Jean-Nicolas