How can I help? And is there a difference between anonsvn and developer svn?

Vladimir Krumstein krumstein at gmail.com
Sun Mar 18 15:08:39 CET 2007


Well, i found where is the bug and below is the patch. I also posted
it as a bug in bug.kde.org. But where is the right place to do such
things? Maybe i should post it in kde-core-devel?
===================================================================
--- kparts/plugin.cpp   (revision 643554)
+++ kparts/plugin.cpp   (working copy)
@@ -273,31 +273,36 @@
                 //kDebug(1000) << "loadPlugins no desktop file found
in " << relPath << endl;
             }
         }
+bool pluginFound = false;
+        // check if parent is not null!
+        if(parent)
+        {
+            // search through already present plugins
+            const QObjectList pluginList = parent->children();

-        // search through already present plugins
-        const QObjectList pluginList = parent->children();
-
-        bool pluginFound = false;
-        for ( QObjectList::ConstIterator it = pluginList.begin(); it
!= pluginList.end() ; ++it )
-        {
-            Plugin * plugin = qobject_cast<Plugin *>( *it );
-            if( plugin && plugin->d->m_library == library )
+
+            for ( QObjectList::ConstIterator it = pluginList.begin();
it != pluginList.end() ; ++it )
             {
-                // delete and unload disabled plugins
-                if( !pluginEnabled )
+                Plugin * plugin = qobject_cast<Plugin *>( *it );
+                if( plugin && plugin->d->m_library == library )
                 {
-                    kDebug( 1000 ) << "remove plugin " << name << endl;
-                    KXMLGUIFactory * factory = plugin->factory();
-                    if( factory )
-                        factory->removeClient( plugin );
-                    delete plugin;
+                    // delete and unload disabled plugins
+                    if( !pluginEnabled )
+                    {
+                        kDebug( 1000 ) << "remove plugin " << name << endl;
+                        KXMLGUIFactory * factory = plugin->factory();
+                        if( factory )
+                            factory->removeClient( plugin );
+                        delete plugin;
+                    }
+
+                    pluginFound = true;
+                    break;
                 }
-
-                pluginFound = true;
-                break;
             }
         }

+
         // if the plugin is already loaded or if it's disabled in the
         // configuration do nothing
         if( pluginFound || !pluginEnabled )


2007/3/18, Stefan Monov <logixoul at gmail.com>:
> On Sunday 18 March 2007 02:19:30 pm Vladimir Krumstein wrote:
> > Is there a difference between anonsvn and deleveloper svn?
> No, they are two places to get absolutely the same thing.
>
> > I ask you
> > because i got a copy of kde4 source from anonymous svn, compiled it and
> it
> > was terrible: konqueror did not even launched, it crashed all the time:(
> This is normal, kde4 is far from stable currently. The libraries are in flux
> and stuff is breaking and repairing all the time.
> A checkout from svn.kde.org will get you the same, only it'll let you
> commit,
> too.
>
> > I'd like to join the developer team and help them.
> As http://techbase.kde.org/Contribute wisely advises, "Getting started at
> coding in KDE is a matter of finding something to fix, and fixing it." ;)
> Or are you looking for suggestions as to what job you can get your hands on
> first? In this case I can't help but others may ;)
>
> Cheers,
> Stefan
> _______________________________________________
> kde-quality mailing list
> kde-quality at kde.org
> https://mail.kde.org/mailman/listinfo/kde-quality
>


More information about the kde-quality mailing list