Kwin snapping fix

Aaron J. Seigo aseigo at kde.org
Tue Sep 20 23:51:51 CEST 2005


On Thursday 25 August 2005 18:38, Eric Froemling wrote:
> I just wanted to pass along a wee little fix I made to kwin in case
> anyone would be kind enough to test it and/or submit it.  I have dual
> monitors and I noticed that window resize snapping was not working on
> the right side of my right monitor, while move-snapping was working
> fine.  I poked around in the code in kdebase/kwin/geometry.cpp and saw
> that in adjustClientPosition(), maxRect is set to the client area
> containing pos+c->rect().center(), while in adjustClientSize it is set
> based off of just c->rect().center().  So in the adjustClientSize case
> maxrect was always getting set to the dimensions of my left monitor.  If
> I change the adjustClientSize version to moveResizeGeom.topLeft() +
> c->rect().center(), all is well.  (moveResizeGeom.topLeft is what gets
> passed in as "p" in adjustClientPosition() anyway so its pretty much the
> same code)

gah.. i don't know why i didn't reply to this one sooner. do you have a patch 
handy? have you passed this on to the kwin matainer (lubos lunak)? if you do 
have a patch but haven't sent this to lubos, please send it to me asap so i 
can test and commit for 3.5

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-quality/attachments/20050920/d3f427bf/attachment.pgp


More information about the kde-quality mailing list