[Kde-print-devel] regarding Bug 124317, Use kpdf to show ... printed PDF file

[Lion Vollnhals]

Hi!

I think i fixed the Bug / Feature Wish 124317,
http://bugs.kde.org/show_bug.cgi?id=124317 .

Allen Winter wanted to open a .ps or .pdf file immediately after
printing into this file. He suggests a dialog asking whether to open the
file or not after printing into it. He cites PDFCreator on Windows which
opens the .pdf file after the print process finishes.

Instead of a dialog i added a checkbox (asking whether to open the file
afterwards) to the print dialog (KPrintDialog). See
http://bugs.kde.org/attachment.cgi?id=21039&action=view) . This checkbox
is only enabled if the selected printer prints to a file. The status of
this checkbox is saved (just as the preview checkbox). The checkbox
introduces two new strings, first the "open afterwards" checkbox-text
and second the corresponding WhatsThis help text. These two strings need
to be translated if this patch is merged.

The printer implementation (KPrinterImpl) checks the saved status of
this checkbox and instructs KDEPrintd to open the output file if needed
(using an additional boolean argument in KDEPrintd::print which defaults
to false alias "not open"). Finally when the print process completes the
output file is opened by using KRun which selects the appropriate
application.

The patch is already uploaded to the bugtracker,
http://bugs.kde.org/attachment.cgi?id=21045&action=view .

I thank you very much for your help Michael.

Is there something i can to do to get a review or even better get this
patch merged?


Lion Vollnhals