D29613: Support multiple entries in XDG_DATA_DIRS

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Why not simply ignore the theme if it's already in `alreayLoadedThemeName`, or at least if `themes.contains(dirName)`? No need to collect the additional theme paths, if they are not used?

INLINE COMMENTS

> grantleethememanager.cpp:147
> +                    auto it = themes.find(dirName);
> +                    if (it != themes.end())
> +                        (*it).addThemePath(dirIt.filePath());

Coding style: braces

REPOSITORY
  R77 PIM: Grantlee Theme

REVISION DETAIL
  https://phabricator.kde.org/D29613

To: dfaure, dvratil, mlaurent, vkrause, skelly
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200521/e8223146/attachment.htm>