D29762: [KJots] Save on exit

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Minor nitpick, otherwise looks good.

INLINE COMMENTS

> kjotswidget.cpp:1238
> +            int res = KMessageBox::warningContinueCancelDetailed(this,
> +                                                                 i18n("Unable to save the note to Akonadi.\n"
> +                                                                      "You can save your note to a local file using the \"File - Export\" menu,\n"

I would drop the "Akonadi" from the sentence. Akonadi is an implementation detail, it should not be visible anywhere in the UI.

> kjotswidget.cpp:1247
> +                                                                 KMessageBox::Notify,
> +                                                                 i18n("Akonadi error message:\n"
> +                                                                      "%1", job->errorString()));

Same here, remove "Akonadi" from the string.

REPOSITORY
  R573 KJots

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29762

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200514/8ed31e40/attachment.htm>