<table><tr><td style="">dvratil accepted this revision.<br />dvratil added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29762">View Revision</a></tr></table><br /><div><div><p>Minor nitpick, otherwise looks good.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29762#inline-170261">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjotswidget.cpp:1238</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">int</span> <span class="n">res</span> <span style="color: #aa2211">=</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">warningContinueCancelDetailed</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                                 <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to save the note to Akonadi.</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                                      <span style="color: #766510">"You can save your note to a local file using the </span><span style="color: #bb6622">\"</span><span style="color: #766510">File - Export</span><span style="color: #bb6622">\"</span><span style="color: #766510"> menu,</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would drop the "Akonadi" from the sentence. Akonadi is an implementation detail, it should not be visible anywhere in the UI.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29762#inline-170262">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjotswidget.cpp:1247</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                                 <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">Notify</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                                 <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Akonadi error message:</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                                      <span style="color: #766510">"%1"</span><span class="p">,</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same here, remove "Akonadi" from the string.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R573 KJots</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29762">https://phabricator.kde.org/D29762</a></div></div><br /><div><strong>To: </strong>poboiko, dvratil<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>