D29530: Add --view option to display incidence

[Allen Winter]

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  (minor) English wording could be improved a bit.  otherwise lgtm

INLINE COMMENTS

> koapp.cpp:92
> +                    if (fetchJob->count() != 1) {
> +                        KMessageBox::sorry(nullptr, i18n("Failed retrieve incience from Akonadi: incidence doesn't exist."));
> +                        return;

"Failed to retrieve incidence from Akonadi: requested incidence does not exist."

> korganizer-view.desktop:3
> +Name=KOrganizer View
> +Comment=Display incidence
> +Type=Application

Display incidence specified by URL?

> korganizer_options.h:42
> +                          {QStringLiteral("view")},
> +                              i18n("View the given incidence"), QStringLiteral("url")));
>  

"Display the specified incidence (by url)" maybe?

REPOSITORY
  R210 KOrganizer

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29530

To: dvratil, #kde_pim, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200508/0d60709f/attachment-0001.htm>