<table><tr><td style="">winterz accepted this revision.<br />winterz added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29530">View Revision</a></tr></table><br /><div><div><p>(minor) English wording could be improved a bit. otherwise lgtm</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29530#inline-169201">View Inline</a><span style="color: #4b4d51; font-weight: bold;">koapp.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fetchJob</span><span style="color: #aa2211">-></span><span class="n">count</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">sorry</span><span class="p">(</span><span style="color: #aa4000">nullptr</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Failed retrieve incience from Akonadi: incidence doesn't exist."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Failed to retrieve incidence from Akonadi: requested incidence does not exist."</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29530#inline-169203">View Inline</a><span style="color: #4b4d51; font-weight: bold;">korganizer-view.desktop:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name=KOrganizer View
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment=Display incidence
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Type=Application
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Display incidence specified by URL?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29530#inline-169202">View Inline</a><span style="color: #4b4d51; font-weight: bold;">korganizer_options.h:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view"</span><span class="p">)},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"View the given incidence"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"url"</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Display the specified incidence (by url)" maybe?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R210 KOrganizer</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29530">https://phabricator.kde.org/D29530</a></div></div><br /><div><strong>To: </strong>dvratil, KDE PIM, winterz<br /><strong>Cc: </strong>winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil<br /></div>