D28181: [contacts/ContactModifyJob] Avoid race condition

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, thanks for the fix. Just move the code to a separate function, please :)

INLINE COMMENTS

> contactmodifyjob.cpp:155-166
> +        ContactPtr contact = d->contacts.current();
> +        const QUrl photoUrl = ContactsService::photoUrl(account()->accountName(), contact->uid());
> +        QNetworkRequest photoRequest(photoUrl);
> +        if (!contact->photo().isEmpty()) {
> +            photoRequest.setHeader(QNetworkRequest::ContentTypeHeader, QLatin1String("image/*"));
> +            d->pendingPhoto.first = contact->photo().rawData();
> +            d->pendingPhoto.second = contact->photo().type();

Please move the code to a new function (e.g. `Private::updatePhoto(const ContactPtr &contact)`)

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D28181

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200321/d7ee742c/attachment.html>