<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28181">View Revision</a></tr></table><br /><div><div><p>Looks good, thanks for the fix. Just move the code to a separate function, please :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28181#inline-160086">View Inline</a><span style="color: #4b4d51; font-weight: bold;">contactmodifyjob.cpp:155-166</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ContactPtr</span> <span class="n">contact</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">contacts</span><span class="p">.</span><span class="n">current</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">photoUrl</span> <span style="color: #aa2211">=</span> <span class="n">ContactsService</span><span style="color: #aa2211">::</span><span class="n">photoUrl</span><span class="p">(</span><span class="n">account</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">accountName</span><span class="p">(),</span> <span class="n">contact</span><span style="color: #aa2211">-></span><span class="n">uid</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QNetworkRequest</span> <span style="color: #004012">photoRequest</span><span class="p">(</span><span class="n">photoUrl</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">contact</span><span style="color: #aa2211">-></span><span class="n">photo</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">photoRequest</span><span class="p">.</span><span class="n">setHeader</span><span class="p">(</span><span class="n">QNetworkRequest</span><span style="color: #aa2211">::</span><span class="n">ContentTypeHeader</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"image/*"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">pendingPhoto</span><span class="p">.</span><span class="n">first</span> <span style="color: #aa2211">=</span> <span class="n">contact</span><span style="color: #aa2211">-></span><span class="n">photo</span><span class="p">().</span><span class="n">rawData</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">pendingPhoto</span><span class="p">.</span><span class="n">second</span> <span style="color: #aa2211">=</span> <span class="n">contact</span><span style="color: #aa2211">-></span><span class="n">photo</span><span class="p">().</span><span class="n">type</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please move the code to a new function (e.g. <tt style="background: #ebebeb; font-size: 13px;">Private::updatePhoto(const ContactPtr &contact)</tt>)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28181">https://phabricator.kde.org/D28181</a></div></div><br /><div><strong>To: </strong>poboiko, dvratil<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>