D28063: Add icons for some menu options in KMail

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Thanks a lot for the changes. I suggested some alternatives, you can use a tool called "Cuttlefish" to preview the icons, if you don't know it yet. It's better to focus on the //name// of the icon rather than what the icon looks like, because with other icon themes the icons may look differently and may not match the intention as much as Breeze does.

INLINE COMMENTS

> kmmainwidget.cpp:3335
>      {
> -        QAction *action = new QAction(i18n("Configure &Filters..."), this);
> +        QAction *action = new QAction(QIcon::fromTheme(QStringLiteral("preferences-other")), i18n("Configure &Filters..."), this);
>          action->setMenuRole(QAction::NoRole);   // do not move to application menu on OS X

How about `dialog-filters`?

> kmmainwidget.cpp:3346
>      {
> -        QAction *action = new QAction(i18n("&Add Account..."), this);
> +        QAction *action = new QAction(QIcon::fromTheme(QStringLiteral("contact-new-symbolic")), i18n("&Add Account..."), this);
>          actionCollection()->addAction(QStringLiteral("accountWizard"), action);

I think `list-resource-add` would be a better icon for this.

> kmmainwidget.cpp:3456
>      {
> -        QAction *action = new QAction(i18n("Jump to Folder..."), this);
> +        QAction *action = new QAction(QIcon::fromTheme(QStringLiteral("folder")), i18n("Jump to Folder..."), this);
>          actionCollection()->addAction(QStringLiteral("jump_to_folder"), action);

Alternatively, `go-jump` icon might be a good choice.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D28063

To: sjolly, #kde_pim_kmail, dvratil
Cc: dvratil, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200315/5ec0ef0e/attachment-0001.html>